Add diffusivity implementation to VanGenuchten model - #99
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 86.25% 85.99% -0.27%
==========================================
Files 13 13
Lines 553 557 +4
==========================================
+ Hits 477 479 +2
- Misses 76 78 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The analytic VanGenuchten.__call__ implementation is validated by tests against the prior K(θ)/C(θ) behavior including first and second derivatives across the domain.
Pull request overview
This PR adds an explicit (closed-form) moisture diffusivity implementation for the VanGenuchten Richards-based model, making VanGenuchten.__call__ compute diffusivity directly rather than via the generic K(θ)/C(θ) path.
Changes:
- Implement
VanGenuchten.__call__with an analytic expression for diffusivityD(θ). - Add a regression test that validates
D(θ)and its first/second derivatives against the existingK(θ)/C(θ)formulation across a representativetheta_range.
File summaries
| File | Description |
|---|---|
src/frontx/models.py |
Adds an analytic VanGenuchten.__call__ diffusivity implementation. |
tests/test_models.py |
Adds tests comparing analytic diffusivity (and its derivatives) to K/C. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.