Skip to content

Add diffusivity implementation to VanGenuchten model - #99

Merged
gerlero merged 1 commit into
mainfrom
vangenuchten
Aug 27, 2026
Merged

Add diffusivity implementation to VanGenuchten model#99
gerlero merged 1 commit into
mainfrom
vangenuchten

Conversation

@gerlero

@gerlero gerlero commented Aug 27, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (b4ca0a3) to head (8db5d65).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   86.25%   85.99%   -0.27%     
==========================================
  Files          13       13              
  Lines         553      557       +4     
==========================================
+ Hits          477      479       +2     
- Misses         76       78       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The analytic VanGenuchten.__call__ implementation is validated by tests against the prior K(θ)/C(θ) behavior including first and second derivatives across the domain.

Pull request overview

This PR adds an explicit (closed-form) moisture diffusivity implementation for the VanGenuchten Richards-based model, making VanGenuchten.__call__ compute diffusivity directly rather than via the generic K(θ)/C(θ) path.

Changes:

  • Implement VanGenuchten.__call__ with an analytic expression for diffusivity D(θ).
  • Add a regression test that validates D(θ) and its first/second derivatives against the existing K(θ)/C(θ) formulation across a representative theta_range.
File summaries
File Description
src/frontx/models.py Adds an analytic VanGenuchten.__call__ diffusivity implementation.
tests/test_models.py Adds tests comparing analytic diffusivity (and its derivatives) to K/C.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@gerlero
gerlero merged commit 0739ddd into main Aug 27, 2026
9 checks passed
@gerlero
gerlero deleted the vangenuchten branch August 27, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants