Skip to content

chore(app-server): preserve protocol event types on turns#14

Merged
gersmann merged 3 commits intomainfrom
fix/app-server-protocol-event-types/sg
Apr 28, 2026
Merged

chore(app-server): preserve protocol event types on turns#14
gersmann merged 3 commits intomainfrom
fix/app-server-protocol-event-types/sg

Conversation

@gersmann
Copy link
Copy Markdown
Owner

No description provided.

Comment thread codex/app_server/_protocol_helpers.py
@github-actions
Copy link
Copy Markdown
Contributor

Codex Autonomous Review:

  • Overall: patch is correct
  • New findings this run: 0
  • Prior unresolved Codex findings still relevant: 0
  • Active findings total: 0

The update unwraps PEP 695 type aliases before computing known methods and adds tests that assert malformed known methods are rejected even in non-strict mode. The change addresses the earlier validation gap without introducing new issues.

Tip: comment with "/codex address comments" to attempt automated fixes for unresolved review threads.

@gersmann gersmann merged commit edc49bd into main Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant