[Aikido] Fix security issue in @xmldom/xmldom via minor version upgrade from 0.7.13 to 0.8.13 in with-react-native#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade @xmldom/xmldom to fix XML injection vulnerability via unvalidated processing instruction data that allows arbitrary node injection.
✅ Code not affected by breaking changes.
✅ No breaking changes from the @xmldom/xmldom upgrade (0.7.13 => 0.8.13) affect this codebase.
The package is only present as a transitive dependency through
@expo/plistandplistpackages, and there is no direct usage of:XML parsing or serialization APIs (
DOMParser,XMLSerializer)Deprecated exports from
lib/dom-parser.jsXML attribute values with literal
\t,\n, or\rcharactersAny code that would be affected by line ending normalization changes
The upgrade is handled internally by the dependency packages and does not impact the application code.
All breaking changes by upgrading @xmldom/xmldom from version 0.7.13 to 0.8.13 (CHANGELOG)
\nand no longer preserved.\t,\nor\rin attribute values; these must now be represented as numerical character references (e.g.	,
,
) to be preserved.DOMImplementationandXMLSerializerremoved fromlib/dom-parser.js; use the main package export instead.✅ 1 CVE resolved by this upgrade
This PR will resolve the following CVEs:
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.