Pin public access in the manifest - #181
Closed
tosinamuda wants to merge 1 commit into
Closed
Conversation
A scoped package defaults to restricted, so its visibility depended on whoever published remembering `--access public`. Forget it once and the package goes private — which fails loudly on a free account and, on a paid one, succeeds quietly and leaves consumers with a 404. `publishConfig` moves that decision into the file, where it is reviewed like anything else. Verified against a bumped version rather than assumed: with no flag, the dry run reports "public access". It sits beside `files`, which is the other field governing what a publish sends.
Contributor
Author
|
Landed — in the package's own repository, which is where that manifest now lives. This pinned It does its job there — Merging it here would add three lines to a directory #183 removes, so closing instead of merging. Nothing is lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scoped package defaults to
restricted, so@latentic/live-markdown'svisibility depended on whoever published remembering
--access publiconthe command line.
Forget it once and the package goes private. On a free account that fails
loudly; on a paid one it succeeds quietly and every consumer gets a 404 —
which is roughly what we spent ten minutes chasing after the first
publish, before the registry read path caught up.
publishConfigmoves that decision into the file, where it is reviewedlike any other change. It sits beside
files, the other field governingwhat a publish sends.
Verified rather than assumed: bumping the version locally and running
npm publish --dry-runwith no flag reports