Skip to content

build(cargo): Finish workspace dependency inheritance#1243

Open
szokeasaurusrex wants to merge 3 commits into
masterfrom
szokeasaurusrex/inherit-all-deps
Open

build(cargo): Finish workspace dependency inheritance#1243
szokeasaurusrex wants to merge 3 commits into
masterfrom
szokeasaurusrex/inherit-all-deps

Conversation

@szokeasaurusrex

@szokeasaurusrex szokeasaurusrex commented Jul 20, 2026

Copy link
Copy Markdown
Member

cargo autoinherit left path and target-specific dependencies local. Centralize the remaining internal crates and target-only externals, unify internal path deps on default-features = false, and keep shared feature baselines on the workspace entries that every consumer needs (sentry-anyhow/backtrace, sentry-types/protocol).

Also, ensure every sentry dep has a version.

@szokeasaurusrex
szokeasaurusrex requested a review from Litarnus July 20, 2026 12:53
@szokeasaurusrex
szokeasaurusrex marked this pull request as ready for review July 20, 2026 12:53
@szokeasaurusrex
szokeasaurusrex requested a review from a team as a code owner July 20, 2026 12:53
szokeasaurusrex and others added 3 commits July 24, 2026 13:33
Centralize dependency declarations by moving them to the workspace-level `Cargo.toml`.

The changes in this commit were generated with [`cargo autoinherit`](https://github.com/mainmatter/cargo-autoinherit)
`cargo autoinherit` adds `default-features = false` to the workspace definition if used by any of the crate-level dependencies. For most deps, this was apparently fine, but for `actix-web`, we need the `macros` feature in `sentry-actix` dev dependencies.
`cargo autoinherit` left path and target-specific dependencies local. Centralize the remaining internal crates and target-only externals, unify internal path deps on `default-features = false`, and keep shared feature baselines on the workspace entries that every consumer needs (`sentry-anyhow/backtrace`, `sentry-types/protocol`).

Also, ensure every `sentry` dep has a version.
@szokeasaurusrex
szokeasaurusrex force-pushed the szokeasaurusrex/inherit-deps branch from 123f38a to 3de7c85 Compare July 24, 2026 11:34
@szokeasaurusrex
szokeasaurusrex force-pushed the szokeasaurusrex/inherit-all-deps branch from 8de8671 to 4a43c49 Compare July 24, 2026 11:34
Base automatically changed from szokeasaurusrex/inherit-deps to master July 24, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant