Skip to content

feat: add feedback API#1259

Open
xremming wants to merge 1 commit into
getsentry:masterfrom
xremming:zmitchell/add-feedback
Open

feat: add feedback API#1259
xremming wants to merge 1 commit into
getsentry:masterfrom
xremming:zmitchell/add-feedback

Conversation

@xremming

@xremming xremming commented Jul 22, 2026

Copy link
Copy Markdown

Continues the work from #1033.

I personally need this feature so though I might as well finish the partial PR. Largely done together with Claude.

Splitted the change of the type field from a String to en enum into its own commit. Based on my investigations, the whole type field is not actually needed.

Issues

@sdk-maintainer-bot

Copy link
Copy Markdown

👋 Thanks for sending this our way! Before a maintainer reviews the code, we ask community contributors to align with us on the approach first — it keeps your time pointed at changes we can land.

The easiest way is to open or find a GitHub issue and discuss the approach with a maintainer there, then link that issue from this PR. If the issue is already assigned to someone else, please check in with them (or with us) before continuing — otherwise two people may end up working on the same task.

See our contributing guidelines for the full picture.

@xremming
xremming force-pushed the zmitchell/add-feedback branch 3 times, most recently from 46b9076 to a7f744b Compare July 22, 2026 19:59
@xremming
xremming marked this pull request as ready for review July 22, 2026 20:03
@xremming
xremming requested a review from a team as a code owner July 22, 2026 20:03
Comment thread sentry-types/src/protocol/v7.rs
Comment thread sentry-types/src/protocol/envelope.rs
Comment thread sentry-types/src/protocol/v7.rs
@xremming
xremming force-pushed the zmitchell/add-feedback branch from a7f744b to 74e25e6 Compare July 22, 2026 20:28
Comment thread sentry-types/src/protocol/feedback.rs
@xremming
xremming force-pushed the zmitchell/add-feedback branch from 74e25e6 to ccdb79f Compare July 22, 2026 20:49
Comment thread sentry-types/src/protocol/v7.rs Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ccdb79f. Configure here.

Comment thread sentry-types/src/protocol/client_report/mod.rs
Co-authored-by: Zach Mitchell <zmitchell@fastmail.com>
@xremming
xremming force-pushed the zmitchell/add-feedback branch from ccdb79f to 651735a Compare July 22, 2026 21:03
@xremming

Copy link
Copy Markdown
Author

Tested to be working.

image

@xremming

Copy link
Copy Markdown
Author

@szokeasaurusrex Since you had reviewed the previous PR would you be the correct person to ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementing a capture_feedback function

1 participant