fix(types): Support source map debug images#1268
Draft
sidsri14 wants to merge 1 commit into
Draft
Conversation
Accept source map debug images emitted by browser SDKs so events with debug IDs deserialize. Preserve unknown image payloads so future variants do not invalidate otherwise usable events. Fixes getsentry#1267
|
👋 Thanks for sending this our way! Before a maintainer reviews the code, we ask community contributors to align with us on the approach first — it keeps your time pointed at changes we can land. The easiest way is to open or find a GitHub issue and discuss the approach with a maintainer there, then link that issue from this PR. If the issue is already assigned to someone else, please check in with them (or with us) before continuing — otherwise two people may end up working on the same task. See our contributing guidelines for the full picture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourcemapdebug images emitted by browser SDKsTesting
cargo fmt --all -- --checkcargo test --workspace --all-features --all-targets --lockedcargo test --workspace --all-features --doc --lockedcargo test -p sentry --features test --lockedcargo clippy --all-features --workspace --tests --examples --locked -- -D clippy::all.github/workflows/check.ymlcargo +1.88.0 test -p sentry-types --lockedFixes #1267