Skip to content

ggml-webgpu: Fix some binding alias issues to support all archs, fix recurrent-state-rollback test#25931

Open
reeselevine wants to merge 22 commits into
ggml-org:masterfrom
reeselevine:webgpu-all-archs
Open

ggml-webgpu: Fix some binding alias issues to support all archs, fix recurrent-state-rollback test#25931
reeselevine wants to merge 22 commits into
ggml-org:masterfrom
reeselevine:webgpu-all-archs

Conversation

@reeselevine

@reeselevine reeselevine commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Overview

Enable more WebGPU architecture coverage by removing the blanket test skip, while keeping deepseek32 disabled for now. Fix binding aliasing issues in GLU and SSM scan, and handle zero-sized concat inputs.

Fixes the WebGPU CI failures as well.

Requirements

@reeselevine
reeselevine requested review from a team and JohannesGaessler as code owners July 20, 2026 17:19
@github-actions github-actions Bot added testing Everything test related ggml changes relating to the ggml tensor library for machine learning WebGPU labels Jul 20, 2026
@reeselevine
reeselevine marked this pull request as draft July 20, 2026 18:01
@reeselevine
reeselevine marked this pull request as ready for review July 22, 2026 00:56
@reeselevine reeselevine changed the title ggml-webgpu: Add overlap glu variant to support all archs, fix recurrent-state-rollback test ggml-webgpu: Fix some binding alias issues to support all archs, fix recurrent-state-rollback test Jul 22, 2026
Comment thread ggml/src/ggml-webgpu/ggml-webgpu.cpp Outdated
@yomaytk

yomaytk commented Jul 26, 2026

Copy link
Copy Markdown
Member

The test-llama-archs CI test is failing. Does it still need to be addressed?
https://github.com/ggml-org/llama.cpp/actions/runs/30134708680/job/89616184248?pr=25931

@reeselevine

Copy link
Copy Markdown
Contributor Author

It looks like one other model has issues, so I added that to the skip list for now.

@fairydreaming

Copy link
Copy Markdown
Collaborator

@reeselevine Looks like I doubled this work in #26146 yesterday not knowing that this PR exists. Can you summarize your findings about DeepSeek V3.2 failures on macos (I see that it's still disabled in your PR)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning testing Everything test related WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants