ggml-cpu: skip unsupported ARM ISA variants under GGML_CPU_ALL_VARIANTS - #26103
Open
ninihuang2026 wants to merge 1 commit into
Open
ggml-cpu: skip unsupported ARM ISA variants under GGML_CPU_ALL_VARIANTS#26103ninihuang2026 wants to merge 1 commit into
ninihuang2026 wants to merge 1 commit into
Conversation
Assisted-by: Claude Sonnet
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When building with GGML_CPU_ALL_VARIANTS, probe the exact -march= string each ARM variant would be built with and skip it if the compiler rejects it, instead of failing the whole build, because not every compiler version supports every ARM ISA extension (e.g. GCC < 14 rejects "+sme").
Additional information
Test env:
Jetson Orin (Cortex-A78AE, Armv8.2-A, aarch64), Ubuntu 24.04.4 LTS, GCC 13.3.0 (Ubuntu 13.3.0-6ubuntu2~24.04.1)
commands:
===before===
cc1plus: error: invalid feature modifier 'sme' in '-march=armv9.2-a+dotprod+fp16+sve+i8mm+sme'Build exits non-zero, entire GGML_CPU_ALL_VARIANTS build aborts.
===after===
The other 6 ARM variants (armv8.0_1 through armv8.6_2) still probe Success and build with their correct differentiated -march= flags
The full build completes (exit 0) — llama-cli, libllama.so, libggml.so, plus the 6
ggml-cpu-armv8.*.so backend variants.
Requirements