Fix IPN parsing to accept alphanumeric variations#69
Merged
Conversation
The variation segment often codes a value rather than a plain number: 02V5 for 2.5 V, 047n for 47 nH, 8R3m for 8.3 mOhm. reIpn matched four digits only, so those parts failed to parse. Releasing one was refused, the KiCad HTTP API served it without a category, and nextAvailableIPN skipped it when computing the maximum N, which could hand out a number that already existed. parse() now returns V as a string, since it is no longer always a number. newIpnParts and v() took an int variation and had no callers, so they are removed. extractCategory in kicad_api.go parses through the ipn type instead of repeating the format regex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.