refactor(multi-runner): consume effective configuration - #5342
Open
edersonbrilhante wants to merge 15 commits into
Open
refactor(multi-runner): consume effective configuration#5342edersonbrilhante wants to merge 15 commits into
edersonbrilhante wants to merge 15 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
2 times, most recently
from
September 3, 2026 18:14
033527a to
cf49c59
Compare
edersonbrilhante
marked this pull request as ready for review
September 3, 2026 18:32
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 3, 2026 19:02
29643bc to
2c7202c
Compare
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 3, 2026 19:30
2c7202c to
e54c5dd
Compare
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 3, 2026 19:45
e54c5dd to
c8bbc3d
Compare
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 3, 2026 20:12
c22c7a7 to
3f04604
Compare
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 3, 2026 21:11
3f04604 to
27337b9
Compare
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 4, 2026 17:59
7b89929 to
a555fdd
Compare
edersonbrilhante
force-pushed
the
replace-legacy-config-consumers
branch
from
September 7, 2026 15:00
a555fdd to
bd7bf0b
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several effective settings are ignored or dropped, including termination limits, Lambda tags and roles, and SSM housekeeper artifacts.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Routes multi-runner resources through resolved effective configuration while preserving v1 compatibility and adding v2 fixtures.
Changes:
- Migrates runner, webhook, queue, SSM, and housekeeping consumers.
- Adds resolved artifact and settings propagation.
- Expands configuration translation and precedence tests.
File summaries
| File | Description |
|---|---|
webhook.tf |
Uses effective webhook configuration. |
termination-watcher.tf |
Maps effective watcher settings. |
ssm.tf |
Uses effective SSM and GitHub settings. |
runners.tf |
Maps effective lane configuration. |
queues.tf |
Builds queues from effective lanes. |
outputs.tf |
Aligns outputs with effective feature flags. |
main.tf |
Derives tags, credentials, and SSM paths. |
ami-housekeeper.tf |
Uses effective housekeeper configuration. |
tests/config-translation.tftest.hcl |
Expands translation fixtures. |
tests/config-resolution.tftest.hcl |
Tests lane/global precedence. |
tests/config-effective.tftest.hcl |
Tests derived effective values. |
Review details
Suppressed comments (1)
modules/multi-runner/termination-watcher.tf:20
- The resolved termination-watcher
lambda.memory_sizeandlambda.timeoutare no longer forwarded after removing the merge withvar.instance_termination_watcher. Any stable or v2 overrides now fall back to the child Lambda defaults instead of taking effect.
s3_key = try(local.effective_config.compute_provider.aws.ec2.instance_termination_watcher.artifact.s3.key, null)
s3_object_version = try(local.effective_config.compute_provider.aws.ec2.instance_termination_watcher.artifact.s3.object_version, null)
zip = local.effective_config.compute_provider.aws.ec2.instance_termination_watcher.artifact.zip
- Files reviewed: 11/11 changed files
- Comments generated: 8
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| resource "aws_sqs_queue" "queued_builds" { | ||
| for_each = var.multi_runner_config | ||
| for_each = local.effective_config.multi_runner_config |
| module "runners" { | ||
| source = "../runners" | ||
| for_each = local.runner_config | ||
| for_each = local.effective_config.multi_runner_config |
Comment on lines
+141
to
+145
| artifact = { | ||
| zip = each.value.ssm.housekeeper.lambda.artifact.zip | ||
| s3_bucket = try(local.effective_config.lambda.artifact.s3.bucket, null) | ||
| s3_key = try(each.value.ssm.housekeeper.lambda.artifact.s3.key, null) | ||
| s3_object_version = try(each.value.ssm.housekeeper.lambda.artifact.s3.object_version, null) |
Comment on lines
+30
to
+31
| role_path = local.effective_config.roles.path | ||
| role_permissions_boundary = local.effective_config.roles.permissions_boundary |
Comment on lines
+98
to
+99
| role_path = each.value.runner.iam.path | ||
| role_permissions_boundary = each.value.runner.iam.permissions_boundary |
Comment on lines
+15
to
+16
| role_path = local.effective_config.roles.path | ||
| role_permissions_boundary = local.effective_config.roles.permissions_boundary |
| lambda_zip = local.effective_config.orchestration_provider.webhook.lambda.webhook.artifact.zip | ||
| lambda_timeout = local.effective_config.orchestration_provider.webhook.lambda.webhook.timeout | ||
| lambda_memory_size = local.effective_config.orchestration_provider.webhook.lambda.webhook.memory_size | ||
| lambda_tags = local.effective_config.orchestration_provider.webhook.lambda.webhook.tags |
Comment on lines
+60
to
+61
| role_path = local.effective_config.roles.path | ||
| role_permissions_boundary = local.effective_config.roles.permissions_boundary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
local.effective_config.Test Plan
terraform fmt -recursiveterraform validateinmodules/multi-runner— passed with existingami-housekeeperdeprecation warningsterraform testinmodules/multi-runner— 6 passed, 0 failedRelated Issues