Skip to content

refactor(storage): extract GitHub App credentials store - #5357

Open
edersonbrilhante wants to merge 4 commits into
runner-config-housekeepingfrom
github-app-credentials-storage
Open

refactor(storage): extract GitHub App credentials store#5357
edersonbrilhante wants to merge 4 commits into
runner-config-housekeepingfrom
github-app-credentials-storage

Conversation

@edersonbrilhante

Copy link
Copy Markdown
Contributor

Description

Extract GitHubAppCredentialsStore and keep GitHub App credential reads independently backed by SSM. Batched reads, decryption, multi-app parsing, authentication, and rate-limit attribution now use the credentials capability without coupling it to runner-config storage.

Test Plan

  • Added/updated SSM credential, authentication, and rate-limit tests.
  • git diff --check passed.
  • Runtime Yarn tests could not be run locally because the repository's pinned Yarn launcher is unavailable in this environment; CI should provide the full test result.

Related Issues

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from be1c0c7 to c3171e6 Compare September 4, 2026 11:19
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from c3171e6 to 65f97f9 Compare September 4, 2026 11:34
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from 65f97f9 to 52fcf78 Compare September 4, 2026 11:41
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from 52fcf78 to ab9f056 Compare September 4, 2026 11:47
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from ab9f056 to 2e6326c Compare September 4, 2026 12:09
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from 2e6326c to 2f1ce0f Compare September 4, 2026 12:14
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from 2f1ce0f to 4156e30 Compare September 4, 2026 12:22
@edersonbrilhante edersonbrilhante added microvm javascript Pull requests that update Javascript code storage-provider and removed microvm labels Sep 4, 2026
@edersonbrilhante
edersonbrilhante force-pushed the github-app-credentials-storage branch from 9e9a564 to 4ecd082 Compare September 7, 2026 12:43
@edersonbrilhante
edersonbrilhante marked this pull request as ready for review September 7, 2026 13:54
@edersonbrilhante
edersonbrilhante requested a review from a team as a code owner September 7, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code storage-provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant