Skip to content

fix(storage): add SSM adapter diagnostics - #5385

Open
edersonbrilhante wants to merge 1 commit into
runner-config-storage-selectionfrom
ssm-storage-adapter-diagnostics
Open

fix(storage): add SSM adapter diagnostics#5385
edersonbrilhante wants to merge 1 commit into
runner-config-storage-selectionfrom
ssm-storage-adapter-diagnostics

Conversation

@edersonbrilhante

Copy link
Copy Markdown
Contributor

Description

Adds structured diagnostics at the asynchronous AWS SSM storage adapter boundaries. A shared logger factory attaches the canonical aws_ssm provider identity while each adapter keeps its own module name.

Runner-config read and delete failures now preserve their original causes, retryable polling misses remain debug-level events, and terminal failures include bounded error-name chains. Credential values, private keys, Base64 contents, and stored runner configuration values are intentionally excluded from logs. Direct SSM consumer tests now pass only the SSM-specific configuration instead of the generic provider-selection field.

This PR is stacked on #5359.

Test Plan

  • Ran the storage-provider test suite: 9 files and 74 tests passed.
  • Ran the storage-provider TypeScript type-check.
  • Ran ESLint for lambdas/libs/storage-providers.
  • Ran Prettier check for storage-provider TypeScript files.
  • Ran git diff --check and a focused sensitive-log-field scan.

Related Issues

@edersonbrilhante
edersonbrilhante requested a review from a team as a code owner September 7, 2026 12:52
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@edersonbrilhante
edersonbrilhante marked this pull request as draft September 7, 2026 13:39
@edersonbrilhante edersonbrilhante added javascript Pull requests that update Javascript code storage-provider labels Sep 7, 2026
@edersonbrilhante
edersonbrilhante marked this pull request as ready for review September 7, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code storage-provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant