vk: use VK_GOOGLE_display_timing to set present time

[poweifeng]

• Implement Driver::setPresentationTime()
• Some small simplification in VulkanPlatform.cpp

[rafadevai]

why move this? Also the logic is not the same as before

I think its just better to keep it were it was all in one place

[poweifeng]

the flow of setting of context variables is getting spread out, so I'm just trying to do it right after when we know the state. So for instance extensions, it's dependent on instExts, and instExts is immutable at this point. That's why I moved it here. Also it reduces queryAndSetDeviceFeatures's parameters by one.

[rafadevai]

Sadly this gets more complicated with the sharedContext flow since it doesnt have any control of the extensions enabled.

So I still think you keep it all inside the queryAndSetDeviceFeatures and pass down the 2 parameters and everything is in one place, this new change is spreading out where the features are enabled.

And what you need to do is in the

if (sharedContext) {
mDebugUtilsSupported = context.mDebugUtilsSupported = scontext->debugUtilsSupported && enabledDebugUtils;
} else {
context.mDebugUtilsSupported =
setContains(instExts, VK_EXT_DEBUG_UTILS_EXTENSION_NAME);
}

[poweifeng]

there is no longer mDebugUtilsSupported, just mDebugUtilsEnabled.

Supported was a misnomer because you could support it and not enable it.

The shared context issue, I thought about moving it here as well, but maybe too many refactoring. But in case the shared context is there, the value set here will just be overwritten, which is correct.

Let me just move things back for the debug utils to not confuse issues here. But I do want to do another refactoring to clean all this up.

[poweifeng]

resolved.