Add AbslStringify function to CString and CallStack - #10264
Open
bejado wants to merge 3 commits into
Open
Conversation
This reverts commit 268141a.
poweifeng
approved these changes
Aug 4, 2026
| endif() | ||
|
|
||
| if (FILAMENT_USE_ABSEIL_LOGGING) | ||
| target_link_libraries(${TARGET} PUBLIC absl::log) |
Contributor
There was a problem hiding this comment.
I wonder if this increases size as well. But I guess we can just commit and see.
z3moon
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the change made in #10218 in favor of defining
AbslStringifyfriend functions forutils::CStringandutils::CallStack. This has the advantage that it doesn't incur a dependency onstd::ostream.BUGS=[537502416]