Skip to content

Fix race condition and handling of server message notifications in Spanner datastore:#624

Open
copybara-service[bot] wants to merge 1 commit into
masterfrom
cl/942178702
Open

Fix race condition and handling of server message notifications in Spanner datastore:#624
copybara-service[bot] wants to merge 1 commit into
masterfrom
cl/942178702

Conversation

@copybara-service

@copybara-service copybara-service Bot commented Jul 3, 2026

Copy link
Copy Markdown

Fix race condition and handling of server message notifications in Spanner datastore:

  • Defer Pub/Sub ACK until MessageProcessor completes message processing.
  • Verify that a MessageResult was saved to Spanner before ACKing notifications.
  • NACK notifications if the message row is not yet visible in Spanner or if processing fails, allowing Pub/Sub redelivery and backoff to handle retries.

@copybara-service copybara-service Bot added the exported Exported change from internal source label Jul 3, 2026
@copybara-service copybara-service Bot changed the title Fix another flaky test Fix race condition and handling of server message notifications in Spanner datastore: Jul 6, 2026
…anner datastore:

- Defer Pub/Sub ACK until MessageProcessor completes message processing.
- Verify that a MessageResult was saved to Spanner before ACKing notifications.
- NACK notifications if the message row is not yet visible in Spanner or if processing fails, allowing Pub/Sub redelivery and backoff to handle retries.

PiperOrigin-RevId: 942178702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exported Exported change from internal source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants