Fix memory leaks in fakelibusb_test.go - #139
Open
BryanDClark wants to merge 4 commits into
Open
Conversation
zagrodzki
requested changes
Aug 10, 2026
| freeDevicePointer(d) | ||
| delete(f.devices, d) | ||
| } | ||
| for h := range f.handles { |
Collaborator
There was a problem hiding this comment.
it seems like the handling of "handles" should be similar to the transfers - they should not be freed silently, but rather should be reported as a missing close on the handle?
| return (*libusbDevHandle)(unsafe.Pointer(C.malloc(1))) | ||
| } | ||
|
|
||
| func freeDevicePointer(d *libusbDevice) { |
Collaborator
There was a problem hiding this comment.
I think this should go into the test code, we don't touch these pointers directly in non-test code.
Also add a block comment why these helpers are needed, something along the lines of "in tests, the code allocates some C pointers directly, it needs to be able to free them directly too".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.