Fix --//:enable_yosys=0 - #3340
Open
AlexanderViand wants to merge 2 commits into
Open
Conversation
The HEIR_NO_YOSYS branch of buildUnoptimizedBooleanPipeline uses oneShotBufferize and createRemoveUnusedMemRef without including their headers.
AlexanderViand
force-pushed
the
alex/no-yosys-fix
branch
2 times, most recently
from
August 17, 2026 10:57
486d5ae to
59d86c3
Compare
Adds a requires_yosys() constraint helper and applies it via target_compatible_with to all yosys-tagged targets, so wildcard builds and tests skip them automatically when yosys is disabled.
AlexanderViand
force-pushed
the
alex/no-yosys-fix
branch
from
August 17, 2026 11:13
59d86c3 to
4e0222f
Compare
AlexanderViand
changed the title
Collaborator
|
In my view we should just remove the yosys flag entirely. The build is hermetic now and there should be no issues with the build including yosys always. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to build without yosys failed because of missing includes (probably overly eagerly removed by some automated tool because they're only used in preprocessor-gated code?)
This has been around for a bit, and the weekly CI testing no-yosys has been failing because of it https://github.com/google/heir/actions/runs/31916922440/job/95090212968
EDIT: Did that CI ever pass? A bunch of tests do not seem to work for the non-yosys fallback branch, so I've tagged them as "requiring yosys" for now, but it looks like the non-yosys path is quite out of date?