Delete assertAsynchronousClose, migrating callers to assertClosed. - #502
Merged
Conversation
The two are equivalent: `assertAsynchronousClose` _looked_ different because it was checking `instanceof AsynchronousCloseException || instanceof ClosedChannelException` instead of just `instanceof ClosedChannelException`. However, [`AsynchronousCloseException`](https://docs.oracle.com/en/java/javase/26/docs/api/java.base/java/nio/channels/AsynchronousCloseException.html) is a subtype of `ClosedChannelException`. RELNOTES=n/a PiperOrigin-RevId: 957265648
copybara-service
Bot
force-pushed
the
test_957229338
branch
from
July 31, 2026 19:03
5a0571a to
4bb21de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
assertAsynchronousClose, migrating callers toassertClosed.The two are equivalent:
assertAsynchronousCloselooked different because it was checkinginstanceof AsynchronousCloseException || instanceof ClosedChannelExceptioninstead of justinstanceof ClosedChannelException. However,AsynchronousCloseExceptionis a subtype ofClosedChannelException.RELNOTES=n/a