size apng frame buffer from png bit depth, not sBIT#238
Open
rootvector2 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the APNG decoder picks UINT8 vs UINT16 storage (and bytes_per_pixel, which sizes the frameRaw rows handed to png_progressive_combine_row) from ppf->info.bits_per_sample. SetColorData lowers that to the sBIT significant-bit count, so a 16-bit PNG carrying an sBIT of 8 ends up with 1-byte samples while libpng, with no png_set_scale_16/strip_16 applied, still writes 2-byte samples, overflowing each row by one byte per sample. Pick the depth from the actual png bit depth instead.