pkg/yaml: preserve implicit null in flow mappings - #321
Open
s-johri wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320
An empty scalar gets
flow_plain_allowed = false, so in flow style the emitterfalls back to single quoting and an implicit null becomes
''. This writes thenull explicitly instead, so
a: { b: }formats toa: {b: null}. Block style isuntouched.
I used the explicit
nullspelling because a bare empty scalar is only safe as aflow mapping value, and the parser rejects
a: [x, , y]anda: { : 1 }. Happyto change it if you would rather keep the original bytes.
Added a round trip test in
pkg/yaml/node_test.gothat decodes a document to aNode, encodes it again, and checks the data survives.