feat: API regeneration: 20260525T070136Z#15628
Conversation
feat(dataplex): Add `RequestDataProductAccess` method to request access to `DataAssets` with in a `DataProduct` feat(dataplex): Add `ApprovalWorkflowService` to manage `ChangeRequest` resource feat(dataplex): Add `ModifyEntry` method to `CatalogService` feat(dataplex): Add `UnstructuredDataOptions` message feat(dataplex): Add `Mode` enum in `DataProfileSpec` message feat(dataplex): Add `CancelDataScanJob` method to `DataScanService` feat(dataplex): Add `DataQualityRuleTemplate` message docs: A comment for message `Aspect` is changed docs: A comment for field `view` in message `.google.cloud.dataplex.v1.GetEntryRequest` is changed docs: A comment for field `view` in message `.google.cloud.dataplex.v1.LookupEntryRequest` is changed docs: A comment for field `resources` in message `.google.cloud.dataplex.v1.LookupContextRequest` is changed docs: A comment for field `options` in message `.google.cloud.dataplex.v1.LookupContextRequest` is changed docs: A comment for field `context` in message `.google.cloud.dataplex.v1.LookupContextResponse` is changed docs: A comment for field `data_scan_id` in message `.google.cloud.dataplex.v1.CreateDataScanRequest` is changed docs: A comment for message `DataScan` is changed docs: A comment for field `resource` in message `.google.cloud.dataplex.v1.DataSource` is changed PiperOrigin-RevId: 920743950 Source-Link: googleapis/googleapis@1742af7
…t API commit 9275871 fix!: Changed field behavior for an existing field `rollout_kind` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Rollout` fix!: Changed proto3 optional flag of an existing field `allowed_count` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.ErrorBudget` fix!: Changed proto3 optional flag of an existing field `allowed_percentage` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.ErrorBudget` feat: A new value `STRUCT` is added to enum `Type` feat: A new value `LIST` is added to enum `Type` feat: A new value `TYPE_WORKLOAD_SUCCEEDED` is added to enum `Type` feat: A new message `SaasCondition` is added feat: A new enum `State` is added feat: A new field `application_template` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Saas` feat: A new field `blueprint_repo` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Saas` feat: A new field `state` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Saas` feat: A new field `conditions` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Saas` feat: A new field `error` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Saas` feat: A new field `application_template_component` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.UnitKind` feat: A new field `app_params` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.UnitKind` feat: A new field `application` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Unit` feat: A new field `satisfies_pzs` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Unit` feat: A new field `satisfies_pzi` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Unit` feat: A new field `delete_time` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.UnitOperation` feat: A new field `application_template_component` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Release` feat: A new message `CompositeRef` is added feat: A new message `ComponentRef` is added feat: A new message `AppParams` is added feat: A new field `effective_unit_filter` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Rollout` feat: A new field `delete_time` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Rollout` feat: A new field `estimated_total_unit_count` is added to message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.RolloutStats` docs: A comment for enum `Type` is changed docs: A comment for message `UnitOperation` is changed docs: A comment for field `rollout_orchestration_strategy` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Rollout` is changed docs: A comment for field `unit_filter` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Rollout` is changed docs: A comment for field `rollout_kind` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.Rollout` is changed docs: A comment for field `operations_by_state` in message `.google.cloud.saasplatform.saasservicemgmt.v1beta1.RolloutStats` is changed PiperOrigin-RevId: 920032530 Source-Link: googleapis/googleapis@9275871
fix: PHP Client Library for the Developer Knowledge API namespace PiperOrigin-RevId: 919826125 Source-Link: googleapis/googleapis@db38aed
google-cloud-sdk-librarian-dotnet-robot
requested a review
from a team
as a code owner
|
Pull request diff results Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.Dataplex.V1 Finding changes in Google.Cloud.NetworkSecurity.V1... Diff level: Minor Comparing with previous NuGet package Diff level: Minor Finished comparisons for Google.Cloud.SaasPlatform.SaasServiceMgmt.V1Beta1 Finding changes in Google.Developers.Knowledge.V1... Comparing with previous NuGet package |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Google.Cloud.NetworkSecurity.V1 library and provides significant updates to Google.Cloud.Dataplex.V1, including new methods for entry modification, data product access requests, and data scan job cancellation. It also incorporates features for unstructured data discovery and lightweight profiling. The review feedback identifies a potential inconsistency in the generated code for the ServiceAccount property and recommends adding default timeouts to new mutation operations to ensure client reliability and consistency with existing methods.
| public string ServiceAccount { | ||
| get { return serviceAccount_ ?? ServiceAccountDefaultValue; } | ||
| set { | ||
| serviceAccount_ = pb::ProtoPreconditions.CheckNotNull(value, "value"); | ||
| } | ||
| } |
There was a problem hiding this comment.
The ServiceAccount property implementation is inconsistent with its inclusion in the TypeOneofCase enum. While it is generated as a standalone field with presence tracking (suggesting proto3_optional), it is also listed as a member of the type oneof. The setter for ServiceAccount does not update typeCase_, which will lead to an inconsistent state where ServiceAccount has a value but TypeCase returns None or another case. This appears to be a generator issue or an invalid proto definition where a field is assigned to two oneofs (the explicit type oneof and a synthetic one for optional).
| /// <item><description>No timeout is applied.</description></item> | ||
| /// </list> | ||
| /// </remarks> | ||
| public gaxgrpc::CallSettings ModifyEntrySettings { get; set; } = gaxgrpc::CallSettings.FromExpiration(gax::Expiration.None); |
There was a problem hiding this comment.
The default settings for ModifyEntry are initialized with Expiration.None. In contrast, other mutation methods in this service (such as CreateEntryLink, UpdateEntryLink, and DeleteEntryLink) have been updated in this PR to include a 60-second timeout. For consistency and to prevent indefinite hangs, a default timeout should be applied to ModifyEntrySettings as well.
public gaxgrpc::CallSettings ModifyEntrySettings { get; set; } = gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000)));| /// <item><description>No timeout is applied.</description></item> | ||
| /// </list> | ||
| /// </remarks> | ||
| public gaxgrpc::CallSettings RequestDataProductAccessSettings { get; set; } = gaxgrpc::CallSettings.FromExpiration(gax::Expiration.None); |
There was a problem hiding this comment.
The default settings for RequestDataProductAccess are initialized with Expiration.None. As this is a mutation operation that triggers a workflow, it should ideally have a default timeout (e.g., 60 seconds) to ensure client calls don't hang indefinitely, consistent with other mutation operations in the library.
public gaxgrpc::CallSettings RequestDataProductAccessSettings { get; set; } = gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000)));| /// <item><description>No timeout is applied.</description></item> | ||
| /// </list> | ||
| /// </remarks> | ||
| public gaxgrpc::CallSettings CancelDataScanJobSettings { get; set; } = gaxgrpc::CallSettings.FromExpiration(gax::Expiration.None); |
There was a problem hiding this comment.
The default settings for CancelDataScanJob are initialized with Expiration.None. Mutation operations should generally have a default timeout to improve reliability and prevent indefinite blocking.
public gaxgrpc::CallSettings CancelDataScanJobSettings { get; set; } = gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000)));
2 participants
Changes in this PR