chore: fix 'multimodel' typo to 'multimodal'#17038
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects the spelling of 'multimodal' (previously 'multimodel') across the codebase, including method names, comments, GCS paths, and test functions. Feedback indicates that several test function names were missed in the renaming process, leading to inconsistencies that should be addressed for uniformity across the repository.
| ): | ||
| df = session.from_glob_path( | ||
| "gs://bigframes-dev-testing/a_multimodel/images/*", name="image" | ||
| "gs://bigframes-dev-testing/a_multimodal/images/*", name="image" |
There was a problem hiding this comment.
Inconsistent typo fix. The function name test_filter_multi_model still contains the 'multi_model' typo. For consistency with other renames in this PR (like test_map_multimodal), please rename it to test_filter_multimodal.
| ): | ||
| df = session.from_glob_path( | ||
| "gs://bigframes-dev-testing/a_multimodel/images/*", name="image" | ||
| "gs://bigframes-dev-testing/a_multimodal/images/*", name="image" |
There was a problem hiding this comment.
Inconsistent typo fix. The function name test_filter_multi_model still contains the 'multi_model' typo. For consistency with other renames in this PR (like test_map_multimodal), please rename it to test_filter_multimodal.
| def test_ai_generate_bool_multi_model(session): | ||
| df = session.from_glob_path( | ||
| "gs://bigframes-dev-testing/a_multimodel/images/*", name="image" | ||
| "gs://bigframes-dev-testing/a_multimodal/images/*", name="image" |
There was a problem hiding this comment.
While you've correctly updated the GCS path, the containing function test_ai_generate_bool_multi_model on line 161 still has the 'multi_model' typo. To be consistent with the changes in other files, this should be renamed to test_ai_generate_bool_multimodal. Please apply this correction to all other test functions in this file that have the same typo (e.g., test_ai_generate_int_multi_model, test_ai_if_multi_model).
sycai
left a comment
sycai
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up! The PR LGTM once we reverted that change in CHANGELOG.md
|
|
||
| ### Bug Fixes | ||
|
|
||
| * Deflake ai_gen_bool multimodel test ([#2085](https://github.com/googleapis/python-bigquery-dataframes/issues/2085)) ([566a37a](https://github.com/googleapis/python-bigquery-dataframes/commit/566a37a30ad5677aef0c5f79bdd46bca2139cc1e)) |
There was a problem hiding this comment.
Maybe we should just keep this typo here.
2 participants
Corrects the typo "multimodel" to "multimodal" across the codebase. This includes internal method names, comments, test functions, and GCS paths in system tests. This aligns the naming with the standard term for models supporting multiple data modalities.
Fixes #<issue_number_goes_here> 🦕