chore: fix mathlib/Std deprecation warnings - #10
Closed
gotrevor wants to merge 4 commits into
Closed
Conversation
Update deprecated names surfaced by the current mathlib/Std: - Set.insert_diff_singleton → insert_sdiff_singleton (Logic/Semantics, Kripke/Completeness) - Irreflexive/Transitive → Std.Irrefl/IsTrans (Vorspiel/List/ChainI) - Reflexive/Symmetric Coherence → explicit ∀-forms (Semantics/CoherenceSpace) - Mathlib.Data.Nat.Lattice → Mathlib.Order.Lattice.Nat (Vorspiel/Nat/Basic) Split out of the Δ₁-definability PR (unrelated cleanup).
…eparate repo (per SnO2WMaN)
… strictly helpful regardless of future migration
- CoherenceSpace.symmetric: back to strict-implicit ⦃x y⦄ (matches the old `Symmetric` def exactly), so ⟨symmetric⟩ and `symmetric h` compile unchanged - ChainI: project the class hypotheses directly with dot-notation (IR.irrefl _ hR, TR.trans _ _ _ …) instead of `letI := _; exact Class.method`, restoring the original succinct one-liners Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
shipped upstream: FormalizedFormalLogic#834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Silence current mathlib/Std deprecation warnings in Foundation:
Set.insert_diff_singleton→Set.insert_sdiff_singleton(Logic/Semantics)Irreflexive/Transitive→Std.Irrefl/IsTrans(Vorspiel/List/ChainI)Reflexive/Symmetric Coherence→ raw∀-forms (∀ x,∀ ⦃x y⦄) +Std.Refl/Std.Symminstances (Semantics/CoherenceSpace/Basic)import Mathlib.Data.Nat.Lattice→Mathlib.Order.Lattice.Nat(Vorspiel/Nat/Basic)Pure API-rename cleanup - no change in what's proved.
🤖 Generated with Claude Code