WIP: calc_tdust_1d: factor out bisect and lightly refactor newton method - #581
Open
mabruzzo wants to merge 47 commits into
Open
WIP: calc_tdust_1d: factor out bisect and lightly refactor newton method#581mabruzzo wants to merge 47 commits into
mabruzzo wants to merge 47 commits into
Conversation
mabruzzo
changed the title
mabruzzo
force-pushed
the
ncc/factor-out-bisect
branch
from
August 20, 2026 01:46
35ec91c to
365c55f
Compare
mabruzzo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be reviewed after #579 has been merged
This is PR factors the bisection logic out of
calc_tdust_1dand lightly refactors the associated newton-raphson logic. Ideally, we will be able to actively test this logic with unit tests.The whole process reveals some interesting assumptions that were made with initial guesses. They were all built around the classic dust model. I'm not sure how robust these assumptions are with Gen's model. It's probably fine, but I don't think we would know if it didn't work (the logic for warning about non-convergence seems broken1).
Footnotes
I left a comment about it in the function, but didn't fix it. ↩