[newchem-cpp] Introduce mass_factor and nuclide properties to c library - #604
Open
mabruzzo wants to merge 68 commits into
Open
[newchem-cpp] Introduce mass_factor and nuclide properties to c library#604mabruzzo wants to merge 68 commits into
mass_factor and nuclide properties to c library#604mabruzzo wants to merge 68 commits into
Conversation
All changes in this commit are a search-and-replace (plus some automated reformatting since the number of characters is changing)
It is now called `add_misc_recipies_to_RegBuilder` and it is now declared at the end of the header file. The old name (and position of the declaration) implied that it acted like a method of RegBuilder
This is inadvisable, but will be necessary to achieve reasonable performance in step_rate_newton_raphson
The default constructor now builds an instance holding 0 elements. The mk_invalid_FrozenKeyIdxBiMap function has beed converted to a private factory method
mabruzzo
force-pushed
the
ncc/mass-factor
branch
from
August 17, 2026 01:15
847b283 to
9096a2b
Compare
mabruzzo
force-pushed
the
ncc/mass-factor
branch
from
August 17, 2026 01:17
9096a2b to
9da7d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after PRs #594, #602, and #603 are merged
This PR does two main things:
mass_factorto the core grackle library. The product of this number andphys_constants.hppto enumerating these values (long term the goal is replace all implicit occurrences of the mass factor).NuclideModeltype. Objects of this type dynamically map between nuclide symbols (e.g. "H", "D", "He", "C") and their properties (namely, the mass_factor and the number of electrons).