Modernize DockPin for v2.2#3
Draft
green2grey wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Babken Egoian <green2grey@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Babken Egoian <green2grey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
git diff --check HEAD~2..HEADpassed.python3 -c "import plistlib; ..."passed and confirmed v2.2/220 plus required plist keys.bash -n build.shpassed.swift package dump-packagepassed and confirmed tools 5.10 plus Sparkle lower bound 2.9.2.swift build -c releasewas attempted but this Linux cloud runner lacks the macOS Cocoa module.swift build -c release -Xswiftc -warnings-as-errors -Xswiftc -strict-concurrency=completewas attempted but this Linux cloud runner lacks the macOS Cocoa module.DOCKPIN_SIGN_ID='Developer ID Application' ./build.shwas attempted and now fails clearly because this runner lacks macOSsecurity/codesign tooling.