Skip to content

Modernize DockPin for v2.2#3

Draft
green2grey wants to merge 2 commits into
mainfrom
cursor/dockpin-v2-2-modernization-e67a
Draft

Modernize DockPin for v2.2#3
green2grey wants to merge 2 commits into
mainfrom
cursor/dockpin-v2-2-modernization-e67a

Conversation

@green2grey

@green2grey green2grey commented May 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix event-tap shared state with a lock-protected snapshot and explicit CFMachPort invalidation.
  • Replace Dock edge polling with Dock preference distributed notifications.
  • Add SwiftUI status popover and setup panel while preserving existing profile, reachability, and re-anchor behavior.
  • Add v2.2 plist metadata, Sparkle 2.9.2, strict concurrency setting, profile error logging, and hardened signing/notarization script.

Testing

  • git diff --check HEAD~2..HEAD passed.
  • python3 -c "import plistlib; ..." passed and confirmed v2.2/220 plus required plist keys.
  • bash -n build.sh passed.
  • swift package dump-package passed and confirmed tools 5.10 plus Sparkle lower bound 2.9.2.
  • swift build -c release was attempted but this Linux cloud runner lacks the macOS Cocoa module.
  • swift build -c release -Xswiftc -warnings-as-errors -Xswiftc -strict-concurrency=complete was attempted but this Linux cloud runner lacks the macOS Cocoa module.
  • DOCKPIN_SIGN_ID='Developer ID Application' ./build.sh was attempted and now fails clearly because this runner lacks macOS security/codesign tooling.
Open in Web Open in Cursor 

Co-authored-by: Babken Egoian <green2grey@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4fd89746-5bc0-4e1f-833b-269b578d81f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/dockpin-v2-2-modernization-e67a

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: Babken Egoian <green2grey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants