Skip to content

Complete the 4-piece bonus for Disenchantment in Deep Shadow#575

Merged
gridhead merged 1 commit into
gridhead:mainfrom
qorexdevs:dids-snezhnaya-bonus
Jun 29, 2026
Merged

Complete the 4-piece bonus for Disenchantment in Deep Shadow#575
gridhead merged 1 commit into
gridhead:mainfrom
qorexdevs:dids-snezhnaya-bonus

Conversation

@qorexdevs

@qorexdevs qorexdevs commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

The 7.0 release fills in the placeholder the 4-piece bonus ended on. The "...toward Snezhnaya" teaser now resolves into the Stellar-Conduct half: Stellar-Conduct Reaction DMG +40%, and the CRIT Rate buff also triggers off Stellar-Conduct.

Updated text to match the finalized in-game string. closes #572

Summary by Sourcery

Enhancements:

  • Extend the 4-piece set bonus to include Stellar-Conduct Reaction DMG and CRIT Rate interactions alongside Superconduct.

@sourcery-ai

sourcery-ai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the 4-piece bonus description for Disenchantment in Deep Shadow to match the finalized in-game effect, adding Stellar-Conduct reaction details and expanding the CRIT Rate condition.

File-Level Changes

Change Details Files
Finalize the 4-piece bonus text for Disenchantment in Deep Shadow to include Stellar-Conduct reaction effects and updated CRIT trigger conditions.
  • Replace the placeholder teaser sentence with the finalized effect description.
  • Add Stellar-Conduct Reaction DMG +40% to the set bonus description alongside Superconduct Reaction DMG +80%.
  • Update the CRIT Rate condition to trigger on attacks against opponents affected by either Superconduct or Stellar-Conduct.
gi_loadouts/data/arti/dids.py

Assessment against linked issues

Issue Objective Addressed Explanation
#572 Update the artifact Disenchantment in Deep Shadow 4-piece bonus description text to match the finalized in-game string for version 7.0 (including the additional description revealed after release).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the artifact set description text (__quadtext__) in gi_loadouts/data/arti/dids.py to include the Stellar-Conduct reaction damage bonus and its CRIT Rate increase effect, replacing a placeholder sentence about Snezhnaya. There are no review comments, and the changes look correct, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gridhead gridhead self-assigned this Jun 29, 2026
@gridhead gridhead modified the milestones: Luna VII, Luna VIII Jun 29, 2026

@gridhead gridhead left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thank you for contributing!

@gridhead gridhead added the enhancement New feature or request label Jun 29, 2026
@gridhead gridhead merged commit 7af230a into gridhead:main Jun 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional description in artifact Disenchantment in Deep Shadow

2 participants