Skip to content

Remove type member in BaseTankParameters because the type decision is… - #1921

Merged
hannesdiedrich merged 1 commit into
masterfrom
remove_hp_parameter_type
Jun 3, 2026
Merged

Remove type member in BaseTankParameters because the type decision is…#1921
hannesdiedrich merged 1 commit into
masterfrom
remove_hp_parameter_type

Conversation

@hannesdiedrich

Copy link
Copy Markdown
Member

… done by isintance(childclass)

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master
SCM_ENGINE_BRANCH=master

@hannesdiedrich
hannesdiedrich requested a review from spyrostz June 3, 2026 09:49
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.63%. Comparing base (fd848d3) to head (a704261).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1921      +/-   ##
==========================================
- Coverage   71.64%   71.63%   -0.01%     
==========================================
  Files         150      150              
  Lines       14644    14640       -4     
  Branches     1908     1908              
==========================================
- Hits        10492    10488       -4     
  Misses       3607     3607              
  Partials      545      545              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spyrostz spyrostz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannesdiedrich
hannesdiedrich merged commit 4896e61 into master Jun 3, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants