Skip to content

Small adaptions to SorTES heat pump strategy - #1922

Merged
hannesdiedrich merged 1 commit into
masterfrom
sortes_small_adaptions
Jun 5, 2026
Merged

Small adaptions to SorTES heat pump strategy#1922
hannesdiedrich merged 1 commit into
masterfrom
sortes_small_adaptions

Conversation

@hannesdiedrich

Copy link
Copy Markdown
Member

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master
SCM_ENGINE_BRANCH=master

@hannesdiedrich
hannesdiedrich requested a review from spyrostz June 3, 2026 13:30
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.63%. Comparing base (a704261) to head (c163038).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
- Coverage   71.63%   71.63%   -0.01%     
==========================================
  Files         150      150              
  Lines       14640    14645       +5     
  Branches     1908     1908              
==========================================
+ Hits        10488    10491       +3     
- Misses       3607     3608       +1     
- Partials      545      546       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spyrostz spyrostz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing to do and I know that we discussed already about it and different parameters are used for different calculations, still the 3 temperature input values look very weird to me. Can you explain these in the public documentation, for example that:

  • ambient temp: used to select the correct value from the performance maps
  • source temp: used for the SOC calculation
  • target temp: used to define the desired target temperature of the building

@hannesdiedrich

Copy link
Copy Markdown
Member Author

LGTM, nothing to do and I know that we discussed already about it and different parameters are used for different calculations, still the 3 temperature input values look very weird to me. Can you explain these in the public documentation, for example that:

  • ambient temp: used to select the correct value from the performance maps
  • source temp: used for the SOC calculation
  • target temp: used to define the desired target temperature of the building

I explained the ambient_temp_C_profile with

 temperature profile of the air temperature at the location of the SorTES tank that is used for selecting the correct performance power of the SorTES tank

For the target temperature I wrote:

 Temperature profile of the targeted condenser temperature in °C

And for the source temperature I referred to the "normal" heat pump wiki.
OK?

@hannesdiedrich
hannesdiedrich merged commit 4385e20 into master Jun 5, 2026
4 checks passed
@hannesdiedrich
hannesdiedrich deleted the sortes_small_adaptions branch June 5, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants