Small adaptions to SorTES heat pump strategy - #1922
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
- Coverage 71.63% 71.63% -0.01%
==========================================
Files 150 150
Lines 14640 14645 +5
Branches 1908 1908
==========================================
+ Hits 10488 10491 +3
- Misses 3607 3608 +1
- Partials 545 546 +1 🚀 New features to boost your workflow:
|
spyrostz
left a comment
There was a problem hiding this comment.
LGTM, nothing to do and I know that we discussed already about it and different parameters are used for different calculations, still the 3 temperature input values look very weird to me. Can you explain these in the public documentation, for example that:
- ambient temp: used to select the correct value from the performance maps
- source temp: used for the SOC calculation
- target temp: used to define the desired target temperature of the building
I explained the ambient_temp_C_profile with For the target temperature I wrote: And for the source temperature I referred to the "normal" heat pump wiki. |
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=master
SCM_ENGINE_BRANCH=master