fix(examples): flatten the market's preview field - #24
Merged
Conversation
The preview sat in a sunken well, and a bevelled rim says "slot" — something you could click into and put an item in. It is a picture of the offer, drawn by the panel, and nothing about it is interactive. Flat now, in both places it exists: the panel paints it and the hover sprite redraws it, so a rim left in either would come back for exactly as long as the cursor was on an offer. Measured after: one colour in the sprite, the same one colour in the panel underneath, and zero pixels between them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview sat in a sunken well, and a bevelled rim says slot — something you could click into. It is a picture of the offer, painted into the panel, and nothing about it is interactive.
Flat now in both places it exists: the panel paints it and the hover sprite redraws it over the blanking patch, so a rim left in either would reappear for exactly as long as the cursor was on an offer.
Measured after:
market_wellis a single colour (FF1F1F1F), the panel under it is that same single colour, and the two differ by zero pixels.139 tests, 0 failures.