fix(config): consume service contract target - #33
Merged
Conversation
lusu007
marked this pull request as ready for review
August 4, 2026 19:15
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Consume the declarative
CONFIG_SERVICE_URLinjected for aconfigservice contract, while retainingCONFIG_GRPC_TARGETas a legacy fallback. This lets bundled proxies enable the service-config-backed network MOTD without carrying a transport-specific environment contract indefinitely.The service-contract value takes precedence when both variables are present. Blank values are ignored.
Type of Change
Related Issues
Testing
Commands run:
./gradlew test./gradlew spotlessApply./gradlew buildprettier --check README.mdChecklist