ci: suppress failure issues on no-op runs for CI Investigator - #1047
ci: suppress failure issues on no-op runs for CI Investigator#1047google-labs-jules[bot] wants to merge 9 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"invalid_fields": [
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
|
@copilot resolve the merge conflicts on this branch. |
There was a problem hiding this comment.
Pull request overview
Updates the CI Investigator’s no-op reporting behavior, but does not resolve #1019’s missing-safe-output failure.
Changes:
- Disables issue reporting for explicit
noopoutputs. - Regenerates the pinned gh-aw lock workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/eventrelay-ci-investigator.md |
Configures no-op reporting. |
.github/workflows/eventrelay-ci-investigator.lock.yml |
Applies the compiled configuration. |
Merge conflicts resolved in commit |
Dependency ReviewThe following issues were found:
|
…gn package-lock.json with npm@10
🔍 PR Validation |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…esolver via `next build --webpack`, which non-deterministically fails to resolve `@/*` tsconfig path-alias imports, breaking the Vercel production build.
This commit fixes the issue reported at apps/web/package.json:7
## Bug
`apps/web/package.json` defines:
```json
"build": "next build --webpack",
```
The `--webpack` flag forces Next.js 16.2.10 to use its legacy webpack resolver instead of the default (Turbopack). That resolver has a defective/non-deterministic tsconfig path-alias (`@/*`) resolution path, producing errors like:
```
./src/app/api/agents/actions/route.ts
Module not found: Can't resolve '@/lib/action-agent'
Module not found: Can't resolve '@/lib/gemini-client'
> Build failed because of webpack errors
```
### Why it happens
* The `tsconfig.json` alias is correct: `"@/*": ["./src/*"]` with `"moduleResolution": "bundler"`.
* All the "missing" files exist on disk and in the git tree.
* Raw `enhanced-resolve` with `alias {'@': src}` resolves every target correctly in isolation.
* The failures are **importer × target specific** and **shift with the module graph** — a bounded set of ~5 alias edges fail, and which ones fail depends on graph/order. This is the signature of a bug in Next 16's legacy webpack tsconfig-paths resolver, not a code error.
### Decisive evidence
`next build` (Turbopack, the Next 16 default) compiles the identical code successfully with **no** module-not-found errors. Only `--webpack` fails.
## Fix
Change the build script to drop `--webpack` and use the Turbopack default:
```json
"build": "next build",
```
This is safe because:
* `next.config.js` already includes a dedicated `turbopack` config block (`turbopack: { root: path.resolve(__dirname, '../..') }`), so the monorepo resolution root is already configured for Turbopack.
* `@sentry/nextjs` is `^10.66.0`; Sentry SDK v9/v10 supports Turbopack builds and source-map upload, so dropping `--webpack` doesn't regress the Sentry integration.
* The Sentry webpack plugin is already disabled in preview/prod when `SENTRY_AUTH_TOKEN` is absent (`disableServerWebpackPlugin`/`disableClientWebpackPlugin`), so it is not a mandatory build step being lost.
The Turbopack build path is verified to resolve the `@/*` aliases correctly, eliminating the `Module not found: @/lib/...` failures.
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: groupthinking <garveyht@gmail.com>
Blocking review — scope far exceeds stated purposeThe stated change ( ❌ Reject —
|
| Branch | Scope | Action |
|---|---|---|
ci/noop-suppression |
the noop: report-as-issue change only, credential gate + test retained |
✅ land |
ci/pr-checks-comment-resilience |
pr-checks.yml |
✅ land |
security/500-disclosure-scanner |
the two test files above | ✅ land |
refactor/autonomous-video-inline |
workflow + scripts/ci/* + their tests |
setup-python; justify test loss |
chore/production-readiness-rewrite |
check_production_readiness.py + its tests |
|
chore/npm-lockfile-refresh |
package-lock.json (+2,958/−3,455 — 59% of all deletions) |
➖ isolate or drop |
Note on CI evidence
This PR is CONFLICTING/DIRTY, so build, CodeQL, trivy, and Coverage never ran. Vercel failed. The change set is substantially unverified.
Split this PR — the fix is correct, the other 99.85% is stale-merge revert damageThe stated fix is sound and I want it landed. The no-op guard cannot swallow real failures: But that fix is 14 lines of a 9,336-line diff — 0.15%.
The branch is 41 commits behind Blocking(a) Removes a required-credential guard that is live on (b) Silent accessibility regression in (c) Deletes (No dangling references — the branch is internally consistent. The problem is that it reverts live work, not that it breaks.) The minimal correct change — 2 files, +2 source linesDo not cherry-pick; both files carry the credential-guard removal.
Recommendation: open that 2-file PR off current |
|
Flagging this as the highest-blast-radius PR currently open — the title and the diff do not describe the same change. Title: "ci: suppress failure issues on no-op runs for CI Investigator." That reads as a narrow CI-hygiene tweak. Actual diff: 32 files, +567 / −2747, including:
Three specific risks:
Recommended: split into (a) the actual CI Investigator no-op suppression, which is the Note (d) will now overlap #1285, which also touches the gate. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Configures 'noop: { report-as-issue: false }' under 'safe-outputs' in the EventRelay CI Investigator workflow frontmatter, and compiles the workflow to regenerate .github/workflows/eventrelay-ci-investigator.lock.yml with the correct settings.
Fixes #1019
PR created automatically by Jules for task 6360156794036608515 started by @groupthinking