docs(triage): PR remediation run 2026-08-03 - #1290
Conversation
#1257) The generated FastAPI project looked deployable and passed a naive smoke test while being non-functional. `/api/health` returned the literal `"2024-01-01T00:00:00Z"`, so the probe could not distinguish a live process from a wedged one or a served cache. Auth, database and message routes returned convincing 200-shaped payloads with no implementation behind them. Rule applied to the template: implement everything the generator can genuinely implement; make everything it cannot fail loudly with 501. A stub that answers successfully teaches operators to trust a lie. - `/api/health` evaluates `datetime.now(timezone.utc)` per request - `/` reports its own gaps via `UNIMPLEMENTED_ENDPOINTS` - `/api/messages` backed by a real (documented non-persistent) store; POST now returns 201 - `POST /auth/login` and `GET /api/data` return 501 with instructions - `create_access_token` / `decode_access_token` are real implementations Also in the same template: - `SECRET_KEY` no longer defaults to `secrets.token_urlsafe(32)`. A per-process random secret invalidates every token on restart and rejects tokens minted by sibling workers, surfacing as intermittent logouts rather than as the misconfiguration it is. It now reads env and fails closed at signing time. - `passlib[bcrypt]` pinned in generated requirements; the template imports `passlib.context`, so auth projects failed at import. - `HTTPException` import made conditional, unused `secrets` dropped, `JWTError` given a real use. Tests execute the generated app with `TestClient` rather than grepping its source, since the defect was behavioural: two health calls must return different, timezone-aware, near-now timestamps. Closes #1257 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Entry scan + action pass over 70 open PRs (65 draft, 5 ready). - #1285, #1288: green + reviewed, HALTED(awaiting_merge_approval) — one human merge click each (protected branch, no automerge label). - #1289: head SHA == main HEAD; content already merged as #1257. DEFERRED(superseded) — recommend close. - #1280, #1281: failing agent-completion/truth-gate with invalid_payload. Systemic blocker (~47 PRs): agent-heuristic branches marked applicable but lacking a linked AgentTask emit null agent_login/run_id. Not per-PR fixable; #1285 only surfaces the reason, does not unblock. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wb9kecMa73hrbA23RPE2o2
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"invalid_fields": [
"issue.number",
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
|
Blocker (expected, not fixable in-PR): The verdict's I am deliberately not pushing a "fix" for this:
Human decision requested (per the runbook's Publish Gate): either merge this docs PR despite the provenance gate (it carries no code), or apply the systemic fix tracked in the doc — link an AgentTask, or narrow the gate's applicability heuristic so label/bot PRs without an AgentTask resolve to Generated by Claude Code |
Triggered by webhook pull_request.review_requested on #1289. Prior run wrongly flagged #1289 as superseded (recommend close). That compared its head SHA to the local workspace tip (a15e4bd, which was #1289's own head) instead of origin/main. Verified against origin/main (94b517c): - code_generator.py:1172 still emits the constant 2024-01-01 timestamp that #1289 fixes; a15e4bd is not an ancestor of main. - #1289 is mergeable_state=clean, all checks green. Corrected: #1289 is HALTED(awaiting_merge_approval), recommend MERGE. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wb9kecMa73hrbA23RPE2o2
Canonical issue
No single canonical issue — this is the recurring scheduled PR-remediation entry scan + action pass (prior runs: #1044, #1059, #1077, #1177, #1258).
Outcome
Adds
docs/triage/pr-remediation-2026-08-03.md: a full oldest-first status matrix of all 70 open PRs with terminal states, plus diagnosed findings and staged human-gated next commands. Gives a maintainer the exact set of one-click actions to clear the ready PRs.Scope
automergelabel on any open PR,mainis protected).Risk
Verification
origin/main(see finding 2 correction).Production evidence
Not applicable — documentation-only change with no deployable surface.
Key findings (summary)
invalid_payloadtruth-gate is a systemic blocker (~47 PRs incl. fix(a11y): add ARIA label to search clear button #1280, fix(security): route API error responses through formatApiError (#1281) #1281). Agent-heuristic branches are markedapplicablebut lack a linked AgentTask, so the collector emits nullagent_login/run_idand the gate correctly fail-closes. Architectural fix needed (link an AgentTask, or narrow the applicability heuristic). fix(ci): surface collection errors behind invalid_payload truth-gate verdicts #1285 only surfaces the reason — it does not unblock. (This PR's own branch hits the same gate for the same reason — see the thread comment.)origin/main. Verified:origin/mainstill emits the constant2024-01-01T00:00:00Zhealth timestamp fix(codegen): emit a real health timestamp and fail-closed scaffolding #1289 fixes, anda15e4bdis not an ancestor of main. fix(codegen): emit a real health timestamp and fail-closed scaffolding #1289 ismergeable_state: clean, all checks green — recommend MERGE.HALTED(awaiting_merge_approval), one human merge click each.Agent handoff
invalid_payloadis the documented systemic provenance gate — see thread)Agent provenance
Agent-authored (scheduled PR-remediation routine). No provider
run_idor canonical issue is available for this recurring maintenance run, so theagent-lock-manifestis intentionally not fabricated — this PR is a docs artifact, not an AgentTask completion, and is not expected to satisfy the agent-completion truth-gate.