fix(ci): drop stale eventrelay-ci-investigator governance checks - #1317
fix(ci): drop stale eventrelay-ci-investigator governance checks#1317groupthinking wants to merge 1 commit into
Conversation
The EventRelay CI Investigator workflow (.md + .lock.yml) was intentionally removed in 07b8a2e ("noise-only output; per repo cleanup"), but two governance hooks still referenced it, leaving `main` — and every PR branched from it — red: - test_ci_investigator_requires_dedicated_codex_credential asserted the removed workflow files exist, failing the `test` job repo-wide (1 failed, 7919 passed). - .github/workflows/gh-aw-validation.yml still ran `gh aw compile eventrelay-ci-investigator` and diffed its deleted .lock.yml, so the gh-aw Validation workflow would fail against files that no longer exist. Codify the removal instead: assert the investigator files stay absent (mirroring test_obsolete_agentic_verification_loop_removed) and drop the investigator from the gh-aw validation compile/diff steps and its pin test. canonical-pr-remediator and focused-coverage-controller remain the authoritative agentic workflows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011GfJq7eGJ3FgkwJHu1YUYi
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"collection_errors": [
"incomplete_linked_issue_contract",
"missing_linked_issue",
"missing_closing_issue_reference",
"missing_agent_run_id",
"missing_agent_login"
],
"invalid_fields": [
"issue.number",
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
|
CI status @ Everything this diff governs is green:
The single red check is This PR is a draft; merge to protected Generated by Claude Code |
Closing: already landed on
|
Canonical issue
Closes #
Outcome
Restores a green
testjob onmain(and therefore on every open PR branched from it). The unit-test suite was failing1 failed, 7919 passedrepo-wide because of a governance test that outlived the workflow it guarded.Scope
tests/unit/test_gh_aw_workflow_governance.py— replacedtest_ci_investigator_requires_dedicated_codex_credential(which asserted the removedeventrelay-ci-investigator.md/.lock.ymlstill exist) withtest_obsolete_ci_investigator_workflow_removed, which codifies the deletion (mirrors the existingtest_obsolete_agentic_verification_loop_removed). Inverted the staleassert "eventrelay-ci-investigator" in combinedintest_gh_aw_validation_pins_runtime_version..github/workflows/gh-aw-validation.yml— removedeventrelay-ci-investigatorfrom bothgh aw compilesteps and from the compiled-lockgit diffstep, so the gh-aw Validation workflow no longer compiles/diffs a source and lock file that no longer exist..github/workflows/AUDIT.mdline 27 — a historical audit-ledger row mentioning the file; left intact as a record (non-breaking).canonical-pr-remediator/focused-coverage-controller, which remain the authoritative agentic workflows.Root cause
Commit
07b8a2e("ci: remove EventRelay CI Investigator workflow source — noise-only output; per repo cleanup") deleted botheventrelay-ci-investigator.mdand.lock.ymlbut left two governance hooks pointing at them: a unit test that required their presence, and the gh-aw validation compile/diff steps. The unit test failure is what has been keeping the repo-widetestgate red across the open-PR backlog.Risk
Verification
Tied to head
6632f75:pytest tests/unit/test_gh_aw_workflow_governance.py→ 9 passed (was 1 failed / 8 passed onmain).gh-aw-validation.ymlre-parsed as valid YAML after edits.eventrelay-ci-investigator(only the AUDIT.md ledger row and the new absence-assertions remain).Production evidence
Not applicable — CI-governance/test-only change; no runtime or deploy surface affected.
Agent handoff
testfailure was this exact stale test.mainAgent provenance
Agent-authored. Opened as draft; merge to protected
mainleft to a human.Generated by Claude Code