test: remove orphaned truth-gate fixture left by #1431 - #1475
Conversation
`ci: retire the agent-completion truth gate (#1431)` (8cd4a10) deleted both readers of tests/fixtures/agent_completion/pr_813.json -- scripts/ci/agent_completion_gate.py and tests/unit/test_agent_completion_gate.py -- but left the fixture itself in the tree. The fixture encodes the retired gate's payload schema (policy.applicable, agent_login, run_id, head_sha). With no reader it reads as a live contract for a mechanism that no longer exists, which is the same misleading-artifact class #1431 and #1434 were closing. Verified orphaned: a repo-wide grep for `agent_completion` outside the fixture directory returns exactly one hit, a historical runbook narrating the retirement (prose, not a load) -- left unchanged. None of the four tests that read from tests/fixtures/ reference it. Closes #1474 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BqvCiGTa8yXRhSsGdHWDgr
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Canonical issue
Closes #1474
Outcome
tests/fixtures/agent_completion/no longer exists.ci: retire the agent-completion truth gate (#1431)(8cd4a10ca) deleted both readers ofpr_813.jsonbut left the fixture in the tree.mainscripts/ci/agent_completion_gate.pytests/unit/test_agent_completion_gate.pytests/fixtures/agent_completion/pr_813.jsonThe fixture encodes the retired gate's payload schema (
policy.applicable,agent_login,run_id,head_sha). With nothing loading it, it reads as a live contract for a mechanism that no longer exists — the same misleading-artifact class #1431 and #1434 were closing.Scope
tests/fixtures/agent_completion/pr_813.json(the directory's only file).docs/runbook/pr-remediation-report-2026-08-04.md:11— the one remainingagent_completionmention in the repo. It is a historical runbook narrating the retirement, not a load of the fixture, and is left unchanged deliberately.Risk
git revert. No runtime, deployed, or data surface.Verification
Head
2994e246, base8c93de8bb. One file,-76.Full unit suite passes with the fixture deleted — the decisive check, since a deletion can only fail by breaking a reader:
Zero failures, zero collection errors. This also independently clears
mainafter the 14-PR merge sweep of 2026-08-07 (d9bab00e→8c93de8b), whose own post-merge CI was still queued when this was run.Orphan status established by exhaustive grep, not assumed:
Exactly one hit, and it is prose. No Python, workflow, or shell reference remains.
Both readers confirmed gone from
main:The four tests that read
tests/fixtures/do not touch it.test_transcript_action_workflow.py,test_gemini_grok_failover.py,test_firestore_state.py,test_backend_main.py— a grep foragent_completionacross all four returns nothing.Required CI — queued. Every GitHub Actions job on this head was still
queued90 s after open; the sweep's 14 pushes saturated the runner pool. Only Vercel's own checks (which do not use GitHub runners) had reported, bothsuccess.Review threads resolved — none open.
Note on the CodeRabbit status
Review skipped: excluded by label configuration, written ~3 s after this PR opened, while thelabeljob was stillqueued— so no labels had been applied yet. This is confounded and should not be cited as evidence for #1424: this PR is also a draft, and.coderabbit.yamlsetsauto_review.drafts: false, which is independently sufficient to explain the skip. #1440 remains the unconfounded case.Production evidence
Not applicable. This deletes a test fixture; it ships no runtime code and has no deployable surface. Nothing under
apps/web/**, soMERGE_POLICY.mdgate 4 (preview) does not apply. The Vercel preview on this head is READY regardless.Agent handoff
tests/fixtures/agent_completion/Agent provenance
Agent-authored under the PR remediation runbook. Found while verifying that #1409 ("arm the truth gate only on a real dispatch contract") is obsolete — that PR patches
docs/agent-completion-truth-gate.mdandtests/unit/test_agent_completion_gate.py, both now deleted frommain. This fixture was the remaining artifact of the same retirement.