fix: sync package-lock.json to satisfy npm ci in trivy Security Scan - #1625
Merged
Conversation
package.json requires @ai-sdk/gateway@^4.0.55 and postcss@^8.5.26 but the lockfile pinned @ai-sdk/gateway@4.0.23 and postcss@8.5.21 (apps/web nested). npm ci --workspace=apps/web --production --legacy-peer-deps aborted at the integrity check, causing the trivy Security Scan job to fail before it could run any vulnerability scans (seen on PRs #1609, #1612, #1621, and on main). Regenerated lockfile with npm install --package-lock-only. Only package-lock.json is touched; no application code changed. Verified: - npm ci --workspace=apps/web --production --legacy-peer-deps: exit 0 - npm ci (full dev): exit 0 - apps/web test suite: 509/509 passed - google/gemini-3.8-flash model pin: unchanged Closes #1624 Co-authored-by: Hayden <groupthinking@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1624
Canonical issue
Issue #1624, open: lockfile out of sync with the manifest, which breaks the dependency install inside the trivy Security Scan job.
The trivy Security Scan job on
mainnever reaches a vulnerability scan becausedocker builddies at:npm ciperforms an integrity check: if the lockfile doesn't satisfypackage.json, it hard-aborts. The mismatch:package.jsonrequires@ai-sdk/gateway^4.0.554.0.23postcss(apps/web nested)^8.5.268.5.21This has blocked Security Scan on PRs #1609, #1612, #1621 and on
mainitself.Outcome
The dependency install resolves again, so the trivy Security Scan job reaches the vulnerability scan instead of dying during install. On head f8659ff the trivy check passes in 3m25s.
No user-facing or runtime behaviour changes: the only file in this PR is
package-lock.json(1 file changed, +82 / -210). Application code, routes, CSP, billing and the model pin are untouched.Scope
Regenerated
package-lock.jsonwithnpm install --package-lock-only --legacy-peer-deps.Only
package-lock.jsonis touched. No application code, routes, model pins, CSP, billing, or pipeline logic changed.@ai-sdk/gateway4.0.23 -> 4.0.73 and nestedpostcss8.5.21 -> 8.5.28, both already inside the rangespackage.jsondeclares.package.json, no application or infrastructure code, no workflow or image build edits, no Vercel environment or billing changes, and thegoogle/gemini-3.8-flashmodel pin is unchanged.Risk
@ai-sdk/gatewayorpostcssbreaks the apps/web build or styling. Contained on this head: build, test, test-frontend and lint-frontend are all green on f8659ff, and the apps/web suite is 509/509.package-lock.json. There is no migration, no state change and no deploy-time coupling, so revert is complete and immediate.Verification
All evidence below is bound to head f8659ff.
Local, by the agent that produced the lockfile:
Production evidence
Agent handoff