test: make TestListVideosOffloading responsiveness assertion timing-relative - #1685
Draft
linear-code[bot] wants to merge 1 commit into
Draft
Conversation
…elative Generated with [Linear](https://linear.app/myxstack/agent-session/99d6bfe9-da60-4b61-9bcb-573e327b4739) Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Contributor
Author
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
groupthinking
added
high-priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestListVideosOffloading::test_event_loop_stays_responsive_while_scan_is_in_flightwas vacuous: the mocked scan blocked onrelease.wait(timeout=2.0), so even an inline (on-loop) implementation eventually unblocked and let all ticks run back-to-back, satisfying the count-only assertion.This rewrites the test to mirror the already-repaired sibling in
TestLearningLogOffloading: each loop tick is timestamped, the worker recordstime.monotonic()when the scan finishes, and the assertion requires ≥3 ticks before the scan completed. An inline implementation pins the loop until the scan returns, yielding zero qualifying ticks and a failure message naming the inline-execution cause.No changes under
src/— the production offloading from #1382 is untouched.Note: the session's budget was exhausted before the repaired test and the negative control (inline revert of
list_videos_v1) could be executed in this environment, so those two acceptance checks have not been run yet.