Skip to content

Optimize transcript no-filter search path #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Draft

Optimize transcript no-filter search path #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cce994
Initial plan
Copilot Sep 8, 2026
56c6c06
perf(web): add transcript no-filter fast path
Copilot Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/web/src/lib/__tests__/transcript-search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ describe('filterSegments — empty/null query behavior (#908)', () => {
segments.length,
);
});

it('returns the original segment array when no filters are active', () => {
expect(filterSegments(segments, { search: '' })).toBe(segments);
});
});

describe('filterSegments — null-safe segment text (#908)', () => {
Expand Down
2 changes: 2 additions & 0 deletions apps/web/src/lib/transcript-search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ export function filterSegments(
segments: readonly TranscriptSegment[],
{ search, speaker }: TranscriptFilter,
): TranscriptSegment[] {
if (!search && !speaker) return segments as TranscriptSegment[];

// Hoisted out of the loop: removes N toLowerCase() allocations per keystroke
// update on long transcripts. This is the optimization PR #972 shipped.
const lowerSearchQuery = search ? search.toLowerCase() : '';
Expand Down