Skip to content

fix(ci): unblock main — align reporting 500 test with sanitized detail #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
groupthinking merged 1 commit into from
Jul 17, 2026
Merged

fix(ci): unblock main — align reporting 500 test with sanitized detail #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/unit/test_cloud_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,7 +1316,11 @@ def test_generate_dashboard_url_service_error(self):
}
)
assert response.status_code == 500
assert "Failed to generate" in response.json()["detail"]
# The 500 body must be sanitized (CWE-209): a static message, never the
# caught exception text. See reporting_routes.generate_dashboard_url.
detail = response.json()["detail"]
assert detail == "Internal server error"
assert "Looker unavailable" not in detail

def test_generate_dashboard_url_missing_fields(self):
"""Missing required fields return 422."""
Expand Down
Loading