docs: restore truth-gate invariants to unblock queue-wide test CI failure - #893
Conversation
… rewrite The `test` CI job is red across the entire open-PR queue on a single assertion in `test_agent_completion_gate.py::CompletionGateDocumentationTests:: test_operator_doc_defines_schemas_and_enforcement` (7424 pass, 1 fail). Commit 0b65565 ("fix(ci): bind truth-gate snapshots and evidence") introduced label-event-only snapshot creation, GITHUB_TOKEN markers that do not recursively trigger `issue_comment`, and resolve/collection/ publication-time base+head SHA equality (stale_base / stale_head), and updated both the workflow and the operator doc together. A later docs-only commit (21d94b5) rewrote the file and reverted those two paragraphs to their pre-0b65565 wording, dropping four phrases the test still asserts: - "Snapshot creation is label-event-only" - "does not recursively trigger `issue_comment`" - "Resolve-time, collection-time, and publication-time PR base and head" - "immutable resolved base/head commit comparison" The behaviours are still implemented in .github/workflows/pr-checks.yml (snapshot-agent-task-intent job, RESOLVED_BASE_SHA/RESOLVED_HEAD_SHA, stale_base/stale_head), so this restores the accurate description rather than weakening the test. Documentation-only change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0183kbEEPheuejZkhiLtrRTD
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"invalid_fields": [
"issue.number",
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
There was a problem hiding this comment.
Pull request overview
Restores truth-gate documentation to match its existing workflow invariants and documentation tests.
Changes:
- Documents label-only intent snapshots and
GITHUB_TOKENbehavior. - Documents base/head SHA consistency and immutable commit comparison.
Summary
The required
testCI job is failing on every open PR in the queue on a single assertion —7424 passed, 1 failed:Root cause (git-archaeology, not guesswork): commit
0b65565("fix(ci): bind truth-gate snapshots and evidence") changed the workflow, the test, and the operator doc together — introducing label-event-only snapshots,GITHUB_TOKENmarkers that don't recursively triggerissue_comment, and resolve/collection/publication-time base+head SHA equality (stale_base/stale_head). A later docs-only commit21d94b5rewrote the file and reverted those two paragraphs to their pre-0b65565wording, dropping four phrases the test still asserts:Snapshot creation is label-event-onlydoes not recursively trigger \issue_comment``Resolve-time, collection-time, and publication-time PR base and headimmutable resolved base/head commit comparisonThe behaviours are still implemented in
.github/workflows/pr-checks.yml(thesnapshot-agent-task-intentjob,RESOLVED_BASE_SHA/RESOLVED_HEAD_SHA,stale_base/stale_head), so this restores the accurate description rather than weakening the test to match a stale doc. Documentation-only change (+2 / -2lines).Linked issue
Fixes #
Verification
python -m unittest tests.unit.test_agent_completion_gate.CompletionGateDocumentationTests→ 3 tests OK (the previously-failing case now passes)testjob expected green with this change;buildjob remains red for an unrelated, upstream reason (see below)Separately observed queue-wide blockers (NOT addressed here)
These affect the whole open-PR queue and are out of scope for this doc fix:
buildjob — ESLint crash, upstream ecosystem gap.eslint src middleware.tsdies withTypeError: Cannot read properties of undefined (reading 'Cjs')at@typescript-eslint/typescript-estree/dist/create-program/shared.js:59(ts.Extension.Cjs). The repo is ontypescript@6.0.3, whose runtime no longer exposes theExtensionenum (the type survives in.d.ts; the runtime value does not). Every published@typescript-eslint8.x — including the newest,8.64.0— still referencests.Extension.*at runtime, so no version bump fixes this, and build(deps-dev): bump typescript from 6.0.3 to 7.0.2 #882 deliberately kept the repo on TS 6 (it reverted the bump to 7). A real resolution needs an upstream typescript-eslint release with TS 6/7 support, or a scoped decision to change the TS/lint toolchain — not a change I could verify in this session, so I did not ship a guess.agent-completion/truth-gate/pr-*status is red queue-wide (publication/invalid_payload), and Vercel preview deploys are failing — both external/config, not code.Agent provenance
Authored by a Claude Code agent session (model
claude-opus-4-8[1m]). No trusted-publisher identity is provisioned in.github/agent-lock/trusted-publishers.json, so no machine-readableagent-lock-manifest/agent-lock-eventis asserted — this is a human-readable provenance note rather than forged enforcement evidence. Please review before merge.🤖 Generated with Claude Code
Generated by Claude Code