[SUPERSEDED by #899] Establish autonomous repository governance and delivery state - #901
[SUPERSEDED by #899] Establish autonomous repository governance and delivery state#901groupthinking with Codex wants to merge 2 commits into
Conversation
|
To use Codex here, create a Codex account and connect to github. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"invalid_fields": [
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
Agent-Logs-Url: https://github.com/groupthinking/EventRelay/sessions/f1b2cd53-63c5-4c24-b327-353b77f54e2b Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
| { | ||
| "framework": "nextjs", | ||
| "installCommand": "cd ../.. && npm install --legacy-peer-deps", | ||
| "ignoreCommand": "bash ../../scripts/deployment/vercel-ignore-command.sh", |
groupthinking
left a comment
There was a problem hiding this comment.
Automated review (head 99deb8c)
Review requested — here are verified findings. Flagging rather than gating; leaving the merge decision to @groupthinking.
🔴 Correctness: the new governance regex misses the owner/repo#NNN closing form
pr-governance.yml and repository-reconciliation.yml both detect the canonical issue with:
/(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+#(\d+)/giThis only matches the bare #NNN form. It does not match the fully-qualified owner/repo#NNN form or the full-URL form — which is exactly what agents use throughout this repo. Verified:
| Body text | Regex captures |
|---|---|
Closes #898 |
898 ✅ |
Closes groupthinking/EventRelay#898 |
(none) ❌ |
Fixes https://github.com/groupthinking/EventRelay/issues/898 |
(none) ❌ |
Consequences:
- This PR would fail its own check. #901's body closes the issue via
Closes groupthinking/EventRelay#898(qualified form), socanonicalIssues.length === 0→ the gate fails with "exactly one closing reference". Sincedraft:false, it would not be exempted. - Competing-PR detection silently under-reports. Any competing PR that references the issue in qualified/URL form is invisible to the scan — defeating the headline feature.
Suggest broadening the pattern, e.g. (?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:[\w.-]+\/[\w.-]+)?#(\d+) plus a full-URL \/issues\/(\d+) branch, with a unit test asserting all three forms resolve to the same issue number.
🟠 Does not resolve the systemic truth-gate blocker
Every open PR (I sampled the full backlog #617→#903) is red on agent-completion/truth-gate/pr-<N> with invalid_payload / gate publication failed. This PR does not touch that logic in pr-checks.yml; its own Phase 9 lists "Resolve the current agent-completion truth-gate invalid_payload fields" as still-open. The strategy here (keep truth-gate advisory, add a separate enforced check) is sound, but the actual unblock isn't in this diff.
🟡 [WIP] title vs draft:false
Title says [WIP] but the PR is marked ready, so downstream draft-exemption logic (including the new pr.draft early-return in pr-governance.yml) treats it as enforced. Recommend keeping it a draft while WIP, or dropping the [WIP] prefix.
✅ Good: pull_request_target used safely
pr-governance.yml runs on pull_request_target with read-only permissions and does not check out PR head code — it only reads pr.body. That avoids the usual pull_request_target privilege-escalation footgun. 👍
Net: the workflow scaffolding is reasonable, but the canonical-issue regex is a blocking correctness bug given how this repo's agents write closing references, and this PR doesn't itself clear the truth-gate that's blocking the backlog.
Generated by Claude Code
|
Superseded by the more advanced canonical governance implementation in #899. #899 already contains the workflow-catalog/audit additions and focused policy tests, has a READY Vercel preview at exact head Before this PR is closed, its only unique potentially reusable scope is the path-aware Vercel preview suppression. That implementation is currently blocked because |
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.