[SUPERSEDED by #903] Restore Google OAuth configuration in Vercel production - #902
[SUPERSEDED by #903] Restore Google OAuth configuration in Vercel production#902groupthinking with Codex wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔍 PR Validation |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Agent Completion Truth Gate: BLOCKEDReasons: Machine-readable verdict{
"details": {
"invalid_fields": [
"policy.agent_login",
"policy.run_id"
]
},
"reasons": [
"invalid_payload"
],
"verdict": "blocked"
} |
Agent-Logs-Url: https://github.com/groupthinking/EventRelay/sessions/a544521e-897d-4b95-97a5-9fd5717ab9dd Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Review — not ready to merge; one production-safety flagHighest-priority concern (potential prod auth outage): this PR narrows the accepted env-var names in ➡️ Before this can safely merge, confirm (per the issue's own unchecked boxes) that Vercel production actually has Blocking gates (independent of the above):
The code/test/doc changes are internally consistent (the test asserts the single-convention source and Generated by Claude Code |
groupthinking
left a comment
There was a problem hiding this comment.
Reviewed the OAuth env standardization (GOOGLE_OAUTH_* → GOOGLE_CLIENT_*). The change is coherent — auth.ts, apps/web/.env.example, LAUNCH_CHECKLIST.md, and the config-source test all line up, and the production deprecation-warning for lingering GOOGLE_OAUTH_* vars is a nice touch. Two items:
1. Should-fix — incomplete migration in the root .env.example. The PR updates apps/web/.env.example but the repo-root .env.example (lines 71-72) still ships the deprecated names:
GOOGLE_OAUTH_CLIENT_ID=
GOOGLE_OAUTH_CLIENT_SECRET=
A developer copying the root example would set the deprecated names and trip the very warning this PR adds. Please update these to GOOGLE_CLIENT_ID / GOOGLE_CLIENT_SECRET for consistency. (grep -rn GOOGLE_OAUTH_ . confirms these are the only remaining references outside the intentional deprecation-warning block in auth.ts.)
2. Deploy caveat (not a code issue). This drops the GOOGLE_OAUTH_* fallback entirely — auth.ts now reads only GOOGLE_CLIENT_ID / GOOGLE_CLIENT_SECRET. Since LAUNCH_CHECKLIST records Google sign-in as already LIVE in production (verified 2026-07-14), if Vercel prod currently holds the creds under the GOOGLE_OAUTH_* names, Google auth will stop activating the moment this merges. The Vercel production env must be switched to the new names in lockstep with the merge. The added console.error will flag stragglers, but it won't restore the fallback.
Note for whoever merges: this PR is subject to the same repo-wide Agent completion enforcement check that is currently failing-closed on every open PR (empty trusted-publisher allowlists — by design), so it can't go green until that's provisioned by a human. That's independent of the code above.
Generated by Claude Code
|
Superseded by #903 for issue #900. #903 covers the same OAuth naming work plus the root environment example and production runbook, and all executable checks on exact head |
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.