Add Commercial Rich Link AB test - #16609
Draft
domlander wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a new AB test:
commercial-rich-links.Why?
This AB test will include a fix for ad insertion around rich links and will reduce restrictions on ads placed around rich links.
The fix
Reduced restrictions
left-colbreakpoint, rich links appear entirely in the left-column. As long as we avoid placing an advert above the paragraph that the rich link targets, we don't need to avoid this element when inserting adverts.mobile/tabletbreakpoints, reduce the amount of space required between the bottom of an advert and the top of a rich link. Currently, a paragraph needs 200px of space between its top and the top of a rich link, and 35px between its top and the bottom of an advert. Rich links are only 140px wide so the visual weight of ads and rich links is not too strong.The following test variants will be included:
controlvariant-fixvariant-uplift