Make customData available to interactive atoms - #16612
Merged
Merged
Conversation
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:08a080ef3fc9fab6ca160f29f86469af6c5045788e98e09c9e72b56e74ece516"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-custom-data-for-interactive-atoms"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-30765"
# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-6bab1afda18b5ba14951366e8fe3877254bdcdc2"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/deployTools --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
frederickobrien
force-pushed
the
custom-data-for-interactive-atoms
branch
from
August 26, 2026 12:44
19d3cd9 to
c1cce7d
Compare
customData available to interactive atomscustomData available to interactive atoms
customData available to interactive atomscustomData available to interactive atoms
frederickobrien
marked this pull request as ready for review
September 2, 2026 15:51
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
frederickobrien
force-pushed
the
custom-data-for-interactive-atoms
branch
from
September 3, 2026 09:06
0634d2e to
0bbf169
Compare
frederickobrien
force-pushed
the
custom-data-for-interactive-atoms
branch
3 times, most recently
from
September 3, 2026 09:19
3512d49 to
269eaf7
Compare
emma-imber
reviewed
Sep 3, 2026
frederickobrien
force-pushed
the
custom-data-for-interactive-atoms
branch
from
September 3, 2026 10:16
084507d to
6bab1af
Compare
frederickobrien
enabled auto-merge
September 3, 2026 10:19
|
Seen on PROD (merged by @frederickobrien 9 minutes and 26 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final domino in the parameterised interactives sequence, this takes the newly available
customDatapassed down with interactive atoms and adds adata-atom-custom-dataattribute to the container if it's there, thereby allowing atoms to access configuration, content, etc. defined in Composer rather than publishing new atoms for even the slightest variation.Custom data set for interactive atoms in Composer...
Is now available in Dotcom through a new data attribute:
Atoms can then use a snippet like this to get the data:
And do with it as it sees fit.