Skip to content

Fix immersive Labs centre rule - #16620

Closed
frederickobrien wants to merge 2 commits into
mainfrom
fix-centre-rule-for-immersive-labs
Closed

Fix immersive Labs centre rule#16620
frederickobrien wants to merge 2 commits into
mainfrom
fix-centre-rule-for-immersive-labs

Conversation

@frederickobrien

Copy link
Copy Markdown
Contributor

Tweaks the CSS for centre rules on immersive Labs articles to only start appearing at the leftCol breakpoint rather than desktop, preventing the visual bug shown below.

Before

image

After

image

@github-actions

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:5a592eb0f888aabc2ecdfe26271c3cf132f69cd5889501d58cf60604814ae2d0

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:5a592eb0f888aabc2ecdfe26271c3cf132f69cd5889501d58cf60604814ae2d0"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-fix-centre-rule-for-immersive-labs"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-30491"

# Refer to image via the GitHub commit SHA tag
# IMAGE_IDENTIFIER=":sha-1883f46c4f2605a828bcdbd04c785139b8215e28"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/deployTools --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@frederickobrien frederickobrien added the fix Departmental tracking: fix label Aug 27, 2026
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Aug 27, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Aug 27, 2026

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Thanks

@frederickobrien

Copy link
Copy Markdown
Contributor Author

Wound up bundling the same fix in with #16621, which got merged first, so closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants