Skip to content

Added support for saving as AVIF - #386

Open
ItalyPaleAle wants to merge 1 commit into
h2non:masterfrom
ItalyPaleAle:avif
Open

Added support for saving as AVIF#386
ItalyPaleAle wants to merge 1 commit into
h2non:masterfrom
ItalyPaleAle:avif

Conversation

@ItalyPaleAle

Copy link
Copy Markdown
Contributor

Added support for converting images to AVIF. This adds avif as a supported type.

Some notes:

  1. Generating AVIF images can be very slow, especially for large ones. I mean, it can take multiple seconds or minutes-but the results are great.
  2. There's currently a bug in libheif that makes the app crash when saving images to HEIF if running on ARM64: Encoding to AVIF crashes on ARM64 strukturag/libheif#608

If the two things above are an issue, I can make AVIF support optional by adding a flag.

(For some reason, the formatter on my machine re-formatted some code blocks and caused a lot of lines to be changed and removed some whitespace... if that's not desired, I can try again and see how I can un-do the formatting changes)

@rluisr

rluisr commented Jun 24, 2023

Copy link
Copy Markdown

+1

@suntong

suntong commented Nov 28, 2023

Copy link
Copy Markdown

AVIF support is warmly welcome, and I badly need it.

Hope this PR can be taken soon...

@cromefire

cromefire commented Dec 23, 2023

Copy link
Copy Markdown

@h2non Sorry for the ping, but did you maybe overlook this or so, as this has been open for almost 2 years now with no feedback (and I've seen you still merge new PRs within a few weeks or so). This would be needed for good AVIF support for Nextcloud...

@suntong

suntong commented Dec 24, 2023

Copy link
Copy Markdown

I couldn't wait so I merge it myself and together with an bunch of other PRs, which is now 11 commits ahead of h2non/imaginary:master -- https://github.com/suntong/imaginary/tree/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants