Fix undeterminate values and return#15
Open
dfateyev wants to merge 2 commits into
Open
Conversation
dfateyev
commented
Jul 11, 2026
dfateyev
commented
Contributor
- Fix two indeterminate values read
- Fix missing return in resolver on Windows
Two indeterminate values were read on error paths: - SMTPReadLine() inspected buf[0] outside the `r > 0` guard, so a recv() that failed or disconnected on the first iteration read the uninitialized one-byte buffer. Move the newline handling inside the `r > 0` block. - main() declared `size_t ret;` without initializing it; if the very first SMTPReadLine() (the banner) failed, the error message printed ret before it was ever assigned. Initialize it to 0. Both are undefined behavior with no functional payoff; the fixes are purely defensive. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
On the __WIN32__ build the method had no return statement, so control fell off the end of a non-void function (undefined behavior, and a -Wreturn-type warning). The Windows path keeps no res_state, so return -1 there; the POSIX path is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.