Skip to content

fix(ratewise): 收斂換算模式 SSOT 與 Codex review 遺留修正#442

Closed
s123104 wants to merge 2 commits into
chore/ratewise-production-governance-v2from
converge/converter-ssot
Closed

fix(ratewise): 收斂換算模式 SSOT 與 Codex review 遺留修正#442
s123104 wants to merge 2 commits into
chore/ratewise-production-governance-v2from
converge/converter-ssot

Conversation

@s123104

@s123104 s123104 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

摘要

收編 converter-ssot-followup 與 merged-pr-review-followups 的缺漏修正至 baseline。

變更

  • deep-link(from/to/amount)不再覆寫 lastConverterView
  • 補回 legacy 單/多幣別偏好一次性遷移;新增 MULTI_CONVERTER_MODE 常數消除魔術字串
  • Codex 遺留:i18n localStorage probe(Safari 隱私模式)、worker img-src https:(v5.5)

測試

  • typecheck ✓ · vitest 75 tests ✓ · worker.js syntax ✓

注意

  • Base 為 governance-v2(stacked PR)
  • 動到 security-headers/src/worker.js(跨 package)
  • changeset: @app/ratewise patch

🤖 Generated with Claude Code

haotool and others added 2 commits June 26, 2026 13:53
- deep-link 進入單幣別頁時略過 useRememberConverterView 寫入,避免覆寫 multi 偏好
- legacy currencyConverterMode 遷移至 lastConverterView;新增 MULTI_CONVERTER_MODE SSOT
- i18n localStorage 可寫探測;split-meow smoke 幣別狀態重置;worker img-src https:

測試:pnpm --filter @app/ratewise typecheck、converterStore 與 useRememberConverterView 75/75 通過

Co-authored-by: Cursor <cursoragent@cursor.com>
@s123104

s123104 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

關閉原因:冗餘且 net-negative。

origin 的 governance-v2 在本分支建立後已領先 5 個 commit,其中 #431(收斂換算模式偏好 SSOT 並修正 deep-link 覆寫)與 #435(收斂 3 個已合併 PR 遺留 Codex 評論)正是本分支的來源工作,已整合至 baseline。本分支基於 5-commit-stale 的本地 v2,真實 delta 僅剩回退(移除既有註解、還原 typescript-eslint 8.59.3 的 as number 修正),無任何淨新增值。

converter SSOT 與 Codex 收尾已由 #431/#435 完成,無需本 PR。

@s123104 s123104 closed this Jun 26, 2026
@s123104 s123104 deleted the converge/converter-ssot branch June 26, 2026 08:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 893bed06fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .changeset/converge-converter-ssot.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant