fix(split-meow): PR 445 審查修復舊支出幣別 fallback#480
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- resolveExpenseCurrency 與 resolveTripCurrency 舊資料改 fallback TWD - 補 currencies 與 HistoryTab smoke 測試對齊 PR 445 審查結論 測試：pnpm typecheck、pnpm test、pnpm lint 全通過 Co-authored-by: Cursor <cursoragent@cursor.com>
s123104
force-pushed
the
review/main-455-445-hotfix
branch
from
22293e4 to
dc4ec15
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveExpenseCurrency/resolveTripCurrency對缺currency的舊支出誤跟全域 KRW，NT$ 帳目切換幣別後仍顯示 ₩ExpenseRecordJSDoc 與 KRW 上線前僅有 TWD 的事實Test plan
pnpm typecheckpnpm test（split-meow 190 tests + 全 workspace）pnpm lintMade with Cursor